Dear Joe Hershberger,
In message <1337108353-28086-2-git-send-email-joe.hershber...@ni.com> you wrote:
> Signed-off-by: Joe Hershberger <joe.hershber...@ni.com>
> Cc: Joe Hershberger <joe.hershber...@gmail.com>
> ---
> Changes for v2:
> - Remove volatile from eth driver API
> - Not using global NetRxPacket (since not casting away volatile)
> Changes for v3:
>
> include/net.h | 25 +++++++++++++------------
> net/bootp.c | 4 ++--
> net/eth.c | 12 +++++-------
> net/net.c | 34 +++++++++++++++++-----------------
> net/rarp.c | 2 +-
> net/tftp.c | 6 +++---
> 6 files changed, 41 insertions(+), 42 deletions(-)
While getting rid of volatile is a good thing in general, I am worried
about the test scope of this patch.
This commit is causing tons of compiler warnings because the
respective changes have only be done in the header file and the net/
code, but they are missing in _all_ network drivers. I wonder which
compile and run time testing has been done with this? I mean, you
decided to pull this into mainline - has it been tested at all ?!?
When are you planning to provide fixes for all these warnings? As is,
the whole build is spoiled. Or should we revert these patches?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The alternative to genuflecting before the god of code-bumming is
finding a better algorithm. It should be clear that none such was
available. If your code is too slow, you must make it faster. If no
better algorithm is available, you must trim cycles.
- t...@alice.uucp (Tom Duff) 29 Aug 88
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
