What are all these commit references? Are they from an external git-repo? If so I think the commit message might make more sense if you simply summarise what you have done to adapt the original source code in order to integrate it into U-Boot
Hmm I assumed --squash would git rid of that history, I guess not. I'll find a way.
Please keep list sorted
I didn't even notice it was sorted. Of course this leave the issue of: COBJS-$(CONFIG_YAFFS2) += cmd_yaffs2.o COBJS-$(CONFIG_CMD_ZFS) += cmd_zfs.o COBJS-$(CONFIG_CMD_SPL) += cmd_spl.o Not sure if I was supposed to go before or after that dangling spl.
Don't include changelogs in source files - We have git for that :)
Can this be aligned better? Personally I prefer to put each parameter on it's own line once I hit the 80 character limit
Keep sorted
All done.
Please don't mess with other devs copyright lines
Oops.
This looks to be an unrelated change - If needed, move this into a seperate patch
Actually, git noticed I copied the ../Makefile and changed it for zfs/Makefile. That's pretty neat.
Insert a blank line
Put the || operator on the previous line and fix vertical alignment of subsequent lines
Ewww, that's a very ugly split
Lesson here is don't assume file taken from ext2/dev.c to be ok :)
'ported to' versus 'implementation' ?
Ah of course.
Is this an identical copyright attribution from the original source?
Changed it to only have original license. Once I test compile and compliance again, I will resend for your scrutiny. Lund -- Jorgen Lundman | <lund...@lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
