On Sat, Jun 09, 2012 at 11:32:08AM -0700, Simon Glass wrote: > Hi Allen, > > On Fri, Jun 8, 2012 at 2:16 PM, Allen Martin > <amar...@nvidia.com<mailto:amar...@nvidia.com>> wrote: > Add support for tegra20 arm7 boot processor. This processor is used > to power on the Cortex A9 and transfer control to it. > > Signed-off-by: Allen Martin <amar...@nvidia.com<mailto:amar...@nvidia.com>> > --- > arch/arm/cpu/arm720t/cpu.c | 2 + > arch/arm/cpu/arm720t/interrupts.c | 4 + > arch/arm/cpu/arm720t/start.S | 6 +- > .../{tegra20-common => arm720t/tegra20}/Makefile | 22 +- > arch/arm/cpu/arm720t/tegra20/board.h | 25 ++ > arch/arm/cpu/arm720t/tegra20/cpu.c | 259 > ++++++++++++++++++++ > arch/arm/cpu/arm720t/tegra20/cpu.h | 99 ++++++++ > arch/arm/cpu/arm720t/tegra20/spl.c | 133 ++++++++++ > arch/arm/cpu/tegra20-common/Makefile | 2 +- > arch/arm/include/asm/arch-tegra20/hardware.h | 29 +++ > > I think this (empty) file is required by arm720t/cpu.c, right?
Yes. > > You are using arm720t here, but your chip is actually an ARM7TDMI. I > suppose that doesn't matter since there is no cache and they share > the same core. But perhaps a comment would be useful explaining this > difference and how it was convenient to use the same code. Good point, will do. -Allen -- nvpublic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
