Dear Otavio Salvador,

In message <[email protected]> you 
wrote:
> Signed-off-by: Otavio Salvador <[email protected]>
> Cc: Marek Vasut <[email protected]>
> Cc: Stefano Babic <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> ---
>  board/freescale/mx53loco/mx53loco.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/board/freescale/mx53loco/mx53loco.c 
> b/board/freescale/mx53loco/mx53loco.c
> index 445d022..5df1b18 100644
> --- a/board/freescale/mx53loco/mx53loco.c
> +++ b/board/freescale/mx53loco/mx53loco.c
> @@ -413,6 +413,11 @@ int board_early_init_f(void)
>       return 0;
>  }
>  
> +/*
> + * Usually this is called too early printing a wrong information about
> + * the clock. To fix it we need to provide this local method and call
> + * it later in board_init.
> + */


I don't like this change. It messes with the initialization sequence,
which is not a good thing. Instead of shift more and more things
backwards, we should fix any incorrect clock calculations here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
A star captain's most solemn oath is that he will give his life, even
his entire crew, rather than violate the Prime Directive.
        -- Kirk, "The Omega Glory", stardate unknown
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to