On 2012/06/28, at 23:57, Tom Rini wrote: > On 06/28/2012 04:35 AM, Tetsuyuki Kobayashi wrote: >> save_boot_params_default() in cpu.c accesses uninitialized stack area >> when it compiled with -O0 (not optimized). >> >> Signed-off-by: Tetsuyuki Kobayashi <k...@kmckk.co.jp> >> --- >> Changes for v2: >> - include <linux/compiler.h> and use __naked instead of >> __attribute__((naked)) >> >> >> arch/arm/cpu/armv7/cpu.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c >> index c6fa8ef..3e2a75c 100644 >> --- a/arch/arm/cpu/armv7/cpu.c >> +++ b/arch/arm/cpu/armv7/cpu.c >> @@ -36,9 +36,13 @@ >> #include <asm/system.h> >> #include <asm/cache.h> >> #include <asm/armv7.h> >> +#include <linux/compiler.h> >> >> +__naked /* don't save anything to stack even if compiled with -O0 */ >> void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3) > > The usual form (here and kernel) is: > void __naked save_boot_params_default(...) > > Same for __weak and so on. Thanks! > Oh, I should grep __naked before posting this. I will try V3.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot