On Wed Jul 11, 2012 at 04:43:19AM -0700, Tom Rini wrote: > On 07/11/2012 04:05 AM, Sughosh Ganu wrote:
<snip> > >> I'm fine saying that we should wrap the call around an #if, but I > >> would expect it to be set in the common case and only not set in > >> custom production boards. > > > > Correct, so all that is needed for SD/MMC loading can still be kept > > separate from, say nand load in the spl.c file, isn't it. So if sd/mmc > > spl load needs heap to be set up, can't it be done only for that > > case. > > Yes, but we don't want to have N locations that set up the heap. We > want one location that will, if the board has defined a heap area, we > set it up. Or to put it another way, calling mem_malloc_init isn't part > of the mmc boot-flow, it's part of the general boot flow. Fair enough. My only concern was just that if some feature is not needed for a board, it should be possible to exclude it out. -sughosh _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
