>> > Generally it is in my opinion a good way to go. >> > >> > However, why we aren't first writing sanity checks for passed arguments? >> >> Simply because I didn't want to ask you to do a lot more unrelated work >> >> :) If you want to split and check the mmc (and fatwrite) argueuments >> >> and then make the DFU series depend on that, by all means please do so! > > Would be cool indeed. > >> > We are adding one more level of abstraction, but don't think of the main >> > problem (checking values of passed arguments)? >> > >> > Anyway we shall wait for Marek's opinion. >> >> Yes, a good idea as well. > > My opinion is that if you'll do the sanity checks, that'd be good. We're right > before .07 release anyway, so the patches will hit the next merge window. Are > you up for doing a lot of unrelated work to make this proper?
I agree with the general sense that adding sanity checking would be good. Just because I was too lazy to add them, doesn't mean I was right. ;) Andy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
