On 09/02/2012 05:43 AM, Wolfgang Denk wrote:
Dear York Sun,

In message <1345226412.6510.38.camel@oslab-l1> you wrote:
On Fri, 2012-08-17 at 12:54 -0500, Kumar Gala wrote:
On Aug 15, 2012, at 7:53 PM, York Sun wrote:

Before proper environment is setup, we extract hwconfig and put it into a
buffer with size HWCONFIG_BUFFER_SIZE. We need to enlarge the buffer to
accommodate longer string. Since this macro is used in multiple files, we
move it into hwconfig.h.

Signed-off-by: York Sun <york...@freescale.com>
---

arch/powerpc/cpu/mpc85xx/cpu_init.c           |    2 --
arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c |    2 --
arch/powerpc/cpu/mpc8xxx/ddr/options.c        |    1 -
include/hwconfig.h                            |    2 ++
4 files changed, 2 insertions(+), 5 deletions(-)

1. I don't think HWCONFIG_BUFFER_SIZE should be getting set in 
include/hwconfig.h, this is unique to FSL 8xxx usage not to hwconfig

If no one else uses this feature, I can move it to
arch/powerpc/include/asm/config.h. How about that?

I cannot see in which way arch/powerpc/include/asm/config.h would be
more FSL 8xxx specific ?


I can put it within

#if defined(CONFIG_MPC85xx) || \
    defined(CONFIG_MPC83xx) || \
    defined(CONFIG_MPC86xx)
#ednif

How about that?

York


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to