On 09/13/2012 11:35 AM, Marek Vasut wrote:
Dear Michal Simek,

[...]

+int board_init(void)
+{
+       icache_enable();

Uh oh ... isn't this on by default when CONFIG_ICACHE_OFF isn't present?

Will check this one.


+       return 0;
+}
+
+int board_late_init(void)
+{
+       return 0;

You don't need this.

Will check it too.


+}
+
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+       int ret = 0;
+
+#if defined(CONFIG_ZYNQ_GEM) && defined(CONFIG_ZYNQ_GEM_BASEADDR0)
+       ret |= zynq_gem_initialize(bis, CONFIG_ZYNQ_GEM_BASEADDR0);

ret |= ? ;-)

The reason is that I will wire axi_ethernet and ethernet lite drivers here too.
If this is the problem I can fix it but the next patch will return it
to this style.


+#endif
+
+       return ret;
+}
+#endif
+
+int dram_init(void)
+{
+       gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
+       return 0;
+}
+
+void reset_cpu(ulong addr)
+{
+       while (1)
+               ;
+}

This is definitelly CPU specific.
[...]

Right, Moving to different folder make sense.

Thanks,
Michal



--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to