On Fri, Sep 14, 2012 at 06:28:53PM +0100, Jos?? Miguel Gon??alves wrote:
> This patch adds the support for Samsung's S3C24XX SoCs that have an ARM926EJS
> core.
> Currently it supports S3C2412, S3C2413, S3C2416 and S3C2450.
> Tested on an S3C2416 platform.
[snip]
> +/*
> + * Reset the cpu by setting up the watchdog timer and let him time out.
> + */
> +void reset_cpu(ulong addr)
> +{
> + struct s3c24xx_watchdog *const watchdog = s3c24xx_get_base_watchdog();
> +
> + /* Disable watchdog */
> + writel(0x0000, &watchdog->wtcon);
> +
> + /* Initialize watchdog timer count register */
> + writel(0x0001, &watchdog->wtcnt);
> +
> + /* Enable watchdog timer; assert reset at timer timeout */
> + writel(WTCON_RSTEN | WTCON_ENABLE, &watchdog->wtcon);
> +
> + while (1)
> + /* loop forever and wait for reset to happen */;
> +}As we're dealing with in another series, this should be __noreturn (from <linux/compiler.h>). Also, please audit your new headers to make sure you aren't adding structs / defines / etc that you aren't using by the end of the series, and make sure to note in the cover letter that you are checkpatch clean or explain away the false positives. Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
