Hi Greg, On Tue, Sep 18, 2012 at 10:00 AM, Greg Topmiller <greg.topmil...@jdsu.com> wrote: > Fabio/Benoit, > > I tried the get_board_rev alone and it worked on my mx51evk. > > In the FSL u-boot version I am using the set_board_rev is: > static inline void set_board_rev(int rev) > { > system_rev |= (rev & 0xF) << 8; > }
So you should call it as "set_board_rev(BOARD_REV2)" , where: #define BOARD_REV2 0x1 I don't think we have boards older than rev2 anymore. Looking at the FSL kernel, there are are some tests for "if (board_is_rev(BOARD_REV_2))" and they should return true from what I can see from the schematics. 841 if (board_is_rev(BOARD_REV_2)) 842 /* BB2.5 */ 843 ret = gpio_get_value(BABBAGE_SD2_CD_2_5); 844 else 845 /* BB2.0 */ 846 ret = gpio_get_value(BABBAGE_SD2_CD_2_0); 847 return ret; With the original patch from Benoit "board_is_rev(BOARD_REV_2)" would return falsem which would then assign the wrong SD2 card detect pin, for example. Regards, Fabio Estevam _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot