Hi Mike, On Fri, Aug 17, 2012 at 9:28 PM, Mike Frysinger <vap...@gentoo.org> wrote: > On Friday 17 August 2012 15:48:20 Joe Hershberger wrote: >> --- a/drivers/net/netconsole.c >> +++ b/drivers/net/netconsole.c >> >> +static int refresh_settings_from_env(void) > > this func always returns 0. why not change it to void to simplify the code > (source and generated) ?
It returns -1 in the case where ncip == 0 in the environment. >> + char *p; > > const OK Thanks, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
