Dear Simon Glass, > Hi Marek, > > On Sun, Sep 30, 2012 at 4:24 PM, Marek Vasut <ma...@denx.de> wrote: > > Dear Simon Glass, > > > >> Hi Marek, > >> > >> On Sun, Sep 30, 2012 at 11:09 AM, Marek Vasut <ma...@denx.de> wrote: > >> > Dear Vadim Bendebury, > >> > > >> >> On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut <ma...@denx.de> wrote: > >> >> > The driver is not used anywhere. It is a dead code and it seems to > >> >> > be falling apart slowly due to bitrot. Remove this driver. > >> >> > >> >> This driver is used in several chromeOS devices which have not quite > >> >> made it upstream yet. Why does it seem falling apart? > >> > > >> > Noone tested it every since, it seems unmaintained to me. This it is > >> > only logical to drop it if there are no users. Will the chromium > >> > devices ever make it upstream? > >> > >> The TPM code is used by coreboot and Tegra Seaboard, both of which are > >> upstream. We are working hard on a third :-) > > > > Where do you enable it on either board? I see this: > OK I see, it seems we are missing some patches upstream. I will > prepare a patch to enable for chromebook-x86.
Ah ok, thanks! > > $ git grep CONFIG_GENERIC_LPC_TPM > > Makefile:LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o > > README: CONFIG_GENERIC_LPC_TPM > > drivers/tpm/Makefile:COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o > > > >> If there is a build problem, please can you let us know? > > > > I don't know, it's not enabled anywhere. It's just code that is there but > > noone uses it. > > I recall a discussion about it, but perhaps nothing happened after > that. Very much don't want this driver removed, as we are working on > upstreaming another board which uses it. Maybe you can bribe me with a chromebook* so I won't push for removal of this code** ;-) * - of course with the chip ** - of course I'm joking! > Regards, > Simon > > >> Regards, > >> Simon > >> > >> >> cheers, > >> >> /vb > >> >> > >> >> > Signed-off-by: Marek Vasut <ma...@denx.de> > >> >> > Cc: Vadim Bendebury <vben...@chromium.org> > >> >> > Cc: Tom Rini <tr...@ti.com> > >> >> > --- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot