On 09/10/2012 12:30, Lukasz Majewski wrote: >> This enforces my comment in previous patch. We have two CONFIG_ >> options, both must be turned on. So at least one is redundant.IMHO >> you can drop both of them if power_board_init() is declared weak. > > I can define power_board_init() as __weak if you are OK with this :-).
IMHO yes, and call it board_power_init(). We know directly from the name that board_* function are often declared weak. > In this case for sure CONFIG_POWER_INIT could be removed. > > I agree that CONFIG_PMIC can be removed from this piece of code. > >> Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
