Hi Graeme,
On Thu, Oct 11, 2012 at 8:55 PM, Graeme Russ <graeme.r...@gmail.com> wrote:
> Hi Simon,
>
> On Fri, Oct 12, 2012 at 12:15 PM, Simon Glass <s...@chromium.org> wrote:
>
>> diff --git a/drivers/input/i8042.c b/drivers/input/i8042.c
>> index c3bc536..99254e4 100644
>> --- a/drivers/input/i8042.c
>> +++ b/drivers/input/i8042.c
>> @@ -607,11 +607,10 @@ static void kbd_led_set(void)
>>
>> static int kbd_input_empty(void)
>> {
>> - int kbdTimeout = KBD_TIMEOUT;
>> + int kbdTimeout = KBD_TIMEOUT * 1000;
>>
>> - /* wait for input buf empty */
>> while ((in8(I8042_STATUS_REG) & 0x02) && kbdTimeout--)
>
> I know this magic number was already here, but later patches introduce
> even more. Any chance these can be cleaned up as well?
Yes, will do.
Regards,
Simon
>
> Regards,
>
> Graeme
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
