Dear Andy Fleming, > On Sun, Sep 30, 2012 at 3:09 PM, Marek Vasut <ma...@denx.de> wrote: > > Some of the boards still used the old PXA_MMC driver instead of the > > new generic one. Use the new one instead so the old can be removed > > and the generic MMC framework can be properly used. > > > > Signed-off-by: Marek Vasut <ma...@denx.de> > > Cc: Andy Fleming <aflem...@freescale.com> > > --- > > > > board/lubbock/lubbock.c | 9 +++++++++ > > board/palmtc/palmtc.c | 9 +++++++++ > > board/pxa255_idp/pxa_idp.c | 9 +++++++++ > > board/trizepsiv/conxs.c | 9 +++++++++ > > include/configs/lubbock.h | 3 ++- > > include/configs/palmtc.h | 3 ++- > > include/configs/pxa255_idp.h | 3 ++- > > include/configs/trizepsiv.h | 3 ++- > > 8 files changed, 44 insertions(+), 4 deletions(-) > > > > diff --git a/board/lubbock/lubbock.c b/board/lubbock/lubbock.c > > index 3527b38..ef2cc24 100644 > > --- a/board/lubbock/lubbock.c > > +++ b/board/lubbock/lubbock.c > > @@ -29,6 +29,7 @@ > > > > #include <netdev.h> > > #include <asm/arch/pxa.h> > > #include <asm/arch/pxa-regs.h> > > > > +#include <asm/arch/regs-mmc.h> > > > > #include <asm/io.h> > > > > DECLARE_GLOBAL_DATA_PTR; > > > > @@ -56,6 +57,14 @@ int board_init (void) > > > > return 0; > > > > } > > > > +#ifdef CONFIG_CMD_MMC > > Do we want to use CONFIG_CMD_MMC for this?
No we don't ... but that's what other boards do use, so ... > That technically just means that the mmc *command* exists, but there > are other reasons to enable the MMC driver (such as storing the > environment or other behind-the-scenes mmc uses). Agreed. > It looks like this was done a handful of other places. I'm thinking we > should use CONFIG_MMC, instead. If you update your patch, I'll submit > a patch which fixes the others. Can you just apply this and then fix them all please? > Andy Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
