Hi Wolfgang, On Wed, Oct 31, 2012 at 4:40 PM, Wolfgang Denk <w...@denx.de> wrote: > Dear Simon, > > In message > <capnjgz3us4yoeqohxozq6vphxhakjdlwfb0hpwhwvnnuaz0...@mail.gmail.com> you > wrote: >> >> >> These changes are required to the patman libraries. This is not a proper >> >> patch yet, just sometime to try out. >> > >> > ...are required. So. And why exactly? Or what is the purpose of >> > these changes? >> >> Just so that people can try the builder if they want to. The patches >> enhance functions in patman, mostly on the git side, so that the >> builder can do its job. For example it needs to clone a repo, checkout >> code into a different directory and work with branches a bit more. >> >> This is not a useful patch for any other purpose (e.g. review) - it is >> just a lump of code. If there is interest in this it will need to be >> turned into proper patches. > > Hm... I apologize, but I'm just an old man, and a bit slow of wits > these days. I cannot review any such code without knowing what it is > suppose to acchieve. Maybe you should add such explanations to the > commit message, even if it's only a WIP patch? I would definitely > appreciate this (as it would help me to understand what this is all > about).
:-) OK I see. I will add a proper commit message so it is properly described, but please do understand it is WIP so far. Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > Half of the people in the world are below average. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot