Hi Hatim, On Tue, Nov 6, 2012 at 2:18 AM, Hatim Ali <hatim...@samsung.com> wrote: > From: Alim Akhtar <alim.akh...@samsung.com> > > Adds a new u-boot command to read current temprature from tmu driver. > > Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> > > diff --git a/common/Makefile b/common/Makefile > index dca2f53..b56ffa2 100644 > --- a/common/Makefile > +++ b/common/Makefile > @@ -159,6 +159,7 @@ COBJS-$(CONFIG_CMD_STRINGS) += cmd_strings.o > COBJS-$(CONFIG_CMD_TERMINAL) += cmd_terminal.o > COBJS-$(CONFIG_CMD_TIME) += cmd_time.o > COBJS-$(CONFIG_SYS_HUSH_PARSER) += cmd_test.o > +COBJS-$(CONFIG_CMD_TMU) += cmd_tmu.o > COBJS-$(CONFIG_CMD_TPM) += cmd_tpm.o > COBJS-$(CONFIG_CMD_TSI148) += cmd_tsi148.o > COBJS-$(CONFIG_CMD_UBI) += cmd_ubi.o > diff --git a/common/cmd_tmu.c b/common/cmd_tmu.c > new file mode 100644 > index 0000000..db0a714 > --- /dev/null > +++ b/common/cmd_tmu.c > @@ -0,0 +1,51 @@ > +/* > + * Copyright (C) 2012 Samsung Electronics > + * Alim Akhtar <alim.akh...@samsung.com> > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > + * MA 02111-1307 USA > + */ > + > +#include <common.h> > +#include <command.h> > +#include <asm/arch/exynos-tmu.h>
This throws up a problem - you are including an exynos header file in a generic file. I suggest you create a new header include/tmu.h and put just the definition of tmu_monitor() into it. Then you can include this file here instead of the exynos one. Other SOCs can then implement the same API. > + > +int do_tmu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > +{ > + int cur_temp; > + > + if (argc < 2) > + return CMD_RET_USAGE; > + > + if (strcmp(argv[1], "curtemp") == 0) { > + if (tmu_monitor(&cur_temp) == -1) > + printf("tmu is in unknow state, temp is invalid\n"); typo: unknow > + else > + printf("Current Temp: %u degrees Celsius\n", > cur_temp); > + } else { > + return CMD_RET_USAGE; > + } > + > + return 0; > +} > + > +U_BOOT_CMD( > + tmu, 2, 1, do_tmu, > + "Thermal Management Unit\n", > + "curtemp - show current cpu temperature in degrees celsius\n" Please make this line and the two printf()s above more consistent - perhaps something like this printf("TMU is in unknown state, temperature is invalid\n"); printf("Current temperature: %u degrees Celsius\n", cur_temp); "curtemp - show current CPU temperature in degrees Celsius\n" > +); > -- > 1.7.2.3 > Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot