Hi Prafulla, On 11/10/2012 08:19 AM, Prafulla Wadaskar wrote: >> On kmcoge5un we faced some serious problems with the memory during >> temperature tests. Reason was that we overwrite some registers for >> memory settings which have to leave untouched. These where registers >> 0x20148 , 0x2014c and 0x20154. >> So writing these registers is prohibited and this patch removes them >> from all km related config files. Even if the problem was only >> seen on kmcoge5un. >> >> Signed-off-by: Holger Brunck <holger.bru...@keymile.com> >> Signed-off-by: Valentin Longchamp <valentin.longch...@keymile.com> >> cc: Prafulla Wadaskar <prafu...@marvell.com> >> --- >> board/keymile/km_arm/kwbimage-memphis.cfg | 6 +++--- >> board/keymile/km_arm/kwbimage.cfg | 6 +++--- >> board/keymile/km_arm/kwbimage_128M16_1.cfg | 25 ++----------------- >> ------ >> board/keymile/km_arm/kwbimage_256M8_1.cfg | 25 ++----------------- >> ------ >> 4 files changed, 10 insertions(+), 52 deletions(-) >> >> diff --git a/board/keymile/km_arm/kwbimage-memphis.cfg >> b/board/keymile/km_arm/kwbimage-memphis.cfg >> index 6df2ad7..5aa0de2 100644 >> --- a/board/keymile/km_arm/kwbimage-memphis.cfg >> +++ b/board/keymile/km_arm/kwbimage-memphis.cfg >> @@ -55,9 +55,9 @@ DATA 0xFFD10008 0x00001100 # MPP Control 2 >> Register >> DATA 0xFFD100E0 0x1B1B1B1B # IO Configuration 0 Register >> DATA 0xFFD20134 0x66666666 # L2 RAM Timing 0 Register >> DATA 0xFFD20138 0x66666666 # L2 RAM Timing 1 Register >> -DATA 0xFFD20154 0x00000200 # CPU RAM Management Control3 Register >> -DATA 0xFFD2014C 0x00001C00 # CPU RAM Management Control1 Register >> -DATA 0xFFD20148 0x00000001 # CPU RAM Management Control0 Register > > I think this should be applicable to other Kirkwood boards too. > >> + >> +# NOTE: Don't write on 0x20148 , 0x2014c and 0x20154, leave them >> untouched! >> +# If not it could cause KW Exceptions during boot in Fast >> Corners/High Voltage > > Since you are removing above three lines, do you think the above comments are > needed in this cfg file? I think you can even remove these comments too > because you are not at all providing configuration for this address. > > I think simple you can remove these lines from the code. >
The comment was meant to be a warning for us for the future because the problems which are due to this writes were hard to debug. I would like to keep them and due to the fact that these are "km only" files it should do no harm. But if you still insist I could also drop them. Just let me know. Regards Holger _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
