Dear Simon Glass,
In message <1349910781-32088-4-git-send-email-...@chromium.org> you wrote:
> From: Gabe Black <gabebl...@chromium.org>
>
> When running from coreboot we don't want this code.
>
> This version works by ifdef-ing out all of the code that would go
> into those sections and all the code that refers to it. The sections are
> then empty, and the linker will either leave them empty for the loader
> to ignore or remove them entirely.
>
> Signed-off-by: Gabe Black <gabebl...@chromium.org>
> Signed-off-by: Simon Glass <s...@chromium.org>
> ---
> Changes in v2:
> - Put CONFIG_NO_RESET_CODE into Makefile instead of source files
What exactly is CONFIG_NO_RESET_CODE ?
There is no documentation anywhere for such a config option as is
mandatory when introducing it, nor is there any comment why it would
be needed, nor are there any users for it.
> Makefile | 7 +++++--
> arch/x86/cpu/Makefile | 5 ++++-
> arch/x86/cpu/u-boot.lds | 3 +++
> 3 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 34d9075..6c2f357 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -212,9 +212,12 @@ endif
> # U-Boot objects....order is important (i.e. start must be first)
>
> OBJS = $(CPUDIR)/start.o
> +OBJS = $(CPUDIR)/start.o
> ifeq ($(CPU),x86)
> -OBJS += $(CPUDIR)/start16.o
> -OBJS += $(CPUDIR)/resetvec.o
> + ifneq ($(CONFIG_NO_RESET_CODE),y)
> + OBJS += $(CPUDIR)/start16.o
> + OBJS += $(CPUDIR)/resetvec.o
> + endif
NAK. Bad indentation, and please do without 'if's or the like.
> --- a/arch/x86/cpu/Makefile
> +++ b/arch/x86/cpu/Makefile
> @@ -28,7 +28,10 @@ include $(TOPDIR)/config.mk
>
> LIB = $(obj)lib$(CPU).o
>
> -START = start.o start16.o resetvec.o
> +START = start.o
> +ifneq ($(CONFIG_NO_RESET_CODE),y)
> +START += resetvec.o start16.o
> +endif
Ditto.
> --- a/arch/x86/cpu/u-boot.lds
> +++ b/arch/x86/cpu/u-boot.lds
> @@ -85,6 +85,8 @@ SECTIONS
> __bios_start = LOADADDR(.bios);
> __bios_size = SIZEOF(.bios);
>
> +#ifndef CONFIG_NO_RESET_CODE
Undocumented.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
If I can have honesty, it's easier to overlook mistakes.
-- Kirk, "Space Seed", stardate 3141.9
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
