Oh blah. You're right, that's why I didn't do it. Thanks for reminding me, Gray.
That context menu is going to have to be replaced at some point with one that can accept asynchronous updates (i.e. new items add themselves to the menu while you're looking at it) as well as some way of displaying the command's preview. Which problably means a JS implementation of a whole new UI component with popup-menu-like-properties, instead of an actual popup menu. --Jono On Wed, Jan 14, 2009 at 2:07 PM, Gray Norton <[email protected]> wrote: > Not sure what the expected lifespan of the existing context menu > implementation is, but wouldn't going to callback-only mean that only > noun_arb_text commands would show up in the context menu (since, as > previously discussed, commands depending on async noun suggestions currently > don't show up in the menu)? > > - Gray > > > On Wed, Jan 14, 2009 at 1:30 PM, Jono <[email protected]> wrote: > >> I think it was mainly the backwards compatibility thing, not a performance >> thing. We could change it to be callback-only; we'd have to rewrite all of >> the built-in nountypes (not too hard), and we'd break any third-party >> nountypes. The only code that calls nountypes is in parser, so that's easy >> enough to change. >> >> --Jono >> >> >> On Tue, Jan 13, 2009 at 10:39 PM, Blair McBride <[email protected]>wrote: >> >>> >>> I think its also an issue of performance. If everything can be gotten >>> from noun types synchronously, then its just one batch job, which is >>> (currently) faster than doing lots of suggestions (or small groups of >>> suggestions) separately. >>> >>> - Blair >>> >>> >>> >>> On 14/01/2009 6:40 AM, Atul Varma wrote: >>> > Hi Edwin, >>> > >>> > I think this might have been an evolutionary oddity; the noun types >>> were >>> > originally synchronous, and later Jono added the ability for them to be >>> > asynchronous, but he probably didn't want to break backwards >>> > compatibility, so kept the synchronous mechanism in-place. He'd be the >>> > best one to answer this question, though; I agree that having "only one >>> > way to do it" would be best. >>> > >>> > - Atul >>> > >>> > P.S. -- Thanks for adding to the author tutorial on the wiki! >>> > >>> > On 1/13/09 5:18 AM, Edwin Khodabakchian wrote: >>> >> I am developing a set of noun types, some of which are async. I >>> >> noticed that the suggest method allows you to either return something >>> >> synchronously or callback asynchronously. Is there a reason why these >>> >> those cases could not be unified into always using the callback >>> >> function? >>> >> Thank you, >>> >> Edwin >>> >> >>> > >>> > > >>> >>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "ubiquity-firefox" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/ubiquity-firefox?hl=en -~----------~----~----~----~------~----~------~--~---
