Did not want to sound that negative: I had little sleep over the last few days and was a little tired yesterday. Debugging sessions are pretty good to get familiar with the code and the ubiquity code is always interesting to read.
I know that you guys have a lot on your plate but I think that it would be worth spending a little bit of time on the feed validation side. It would be really great if when adding a feed, one could get a list of errors. This would be both useful for someone who is building a new command interactively but more importantly for someone who has an existing large feed file which for some reading does not work. Things that would have helped me debug: which line of my feed or which createCommand is generating the error. Right now, the only way to do this is to comment and uncomment each line of the code and by dichotomy determine which is the faulty line. I understand that given the transformation you are doing to the JS content before loading it in the sandbox this is not a trivial task. (on the positive side, this was actually a good way for us to detect that a lot of people are actually using feedly+ubiquity and there withdrawal symptoms when it stops working). Keep up the good work. On Apr 2, 10:56 am, Atul Varma <[email protected]> wrote: > Ugh, sorry about that Edwin, it was my bad--the code I added to allow > RegExps to be used as noun-types caused the error you got. I wish I > could give you your 2 hours back. :( > > Next best thing though is that I've fixed the bug in the "graceful > degradation" way Blair suggested, so using "takes: {}" will have the > same effect as not specifying "takes" at all: > > https://ubiquity.mozilla.com/trac/ticket/634 > > - Atul > > On Apr 2, 4:00 am, Blair McBride <[email protected]> wrote: > > > > > Yes... but it still shouldn't throw like it does. The exception should > > at least be useful (or even better, degrade gracefully). > > > - Blair > > > On 2/04/2009 5:51 PM, satyr wrote: > > > > The relevant part of CreateCommand's document: > > > > {{{ options.takes }}} Defines the primary argument of the command, > > > a.k.a. the direct-object of the verb. A dictionary object with a > > > single property. The name of the property will be the display name > > > of the primary argument. The value of the property must be either a > > > noun type (see > > > https://wiki.mozilla.org/Labs/Ubiquity/Ubiquity_0.1_Nountypes_Reference > > > ) which defines what type of values are valid for the argument, or > > > a regular expression that filters what the argument can consist of. > > > > Since it explicitly says "A dictionary object with a single property", > > > `takes:{}' seems invalid. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "ubiquity-firefox" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/ubiquity-firefox?hl=en -~----------~----~----~----~------~----~------~--~---
