Gunnar Hjalmarsson has proposed merging 
lp:~gunnarhj/ubuntu/lucid/gdm/backports-lp-771661 into 
lp:ubuntu/lucid-backports/gdm.

Requested reviews:
  Martin Pitt (pitti)
  Ubuntu Backporters (ubuntu-backporters)
Related bugs:
  Bug #771661 in gdm (Ubuntu Lucid): "Allow .xsession-errors to be a symlink"
  https://bugs.launchpad.net/ubuntu/lucid/+source/gdm/+bug/771661

For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/lucid/gdm/backports-lp-771661/+merge/59436
-- 
https://code.launchpad.net/~gunnarhj/ubuntu/lucid/gdm/backports-lp-771661/+merge/59436
Your team Ubuntu Backporters is requested to review the proposed merge of 
lp:~gunnarhj/ubuntu/lucid/gdm/backports-lp-771661 into 
lp:ubuntu/lucid-backports/gdm.
=== modified file 'debian/changelog'
--- debian/changelog	2011-04-01 05:16:00 +0000
+++ debian/changelog	2011-04-28 22:56:35 +0000
@@ -1,3 +1,18 @@
+gdm (2.30.2.is.2.30.0-0ubuntu5.2+langfixes~lucid1) lucid-backports; urgency=low
+
+  * Merge proposed update (LP: #771661).
+
+ -- Gunnar Hjalmarsson <ubu...@gunnar.cc>  Thu, 28 Apr 2011 21:12:00 +0200
+
+gdm (2.30.2.is.2.30.0-0ubuntu5.2) lucid-proposed; urgency=low
+
+  * Add 44_xsession-errors_symlink.patch: Don't rename .xsession-errors to
+    .xsession-errors.old if the file is a symlink.  The later code will
+    truncate the file to zero anyway, so even in that case the file won't grow
+    indefinitely. (LP: #771661)
+
+ -- Martin Pitt <martin.p...@ubuntu.com>  Wed, 27 Apr 2011 17:56:59 +0200
+
 gdm (2.30.2.is.2.30.0-0ubuntu5.1+langfixes~lucid1) lucid-backports; urgency=low
 
   * Merge recent security update. (LP: #746694)

=== added file 'debian/patches/44_xsession-errors_symlink.patch'
--- debian/patches/44_xsession-errors_symlink.patch	1970-01-01 00:00:00 +0000
+++ debian/patches/44_xsession-errors_symlink.patch	2011-04-28 22:56:35 +0000
@@ -0,0 +1,35 @@
+From 3d869771f1f48c96788d1e1005b00ebc51d13ce1 Mon Sep 17 00:00:00 2001
+From: Martin Pitt <martin.p...@ubuntu.com>
+Date: Wed, 27 Apr 2011 10:02:54 +0200
+Subject: [PATCH] Allow .xsession-errors to be a symlink
+
+Don't rename .xsession-errors to .xsession-errors.old if the file is a symlink.
+The later code will truncate the file to zero anyway, so even in that case
+the file won't grow indefinitely.
+
+This is handy when the home directory is on NFS and you want to avoid network
+contention when there are buggy programs which spam .xsession-errors.
+
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=639527
+Bug-Ubuntu: https://launchpad.net/bugs/771661
+---
+ daemon/gdm-session-worker.c |    3 ++-
+ 1 files changed, 2 insertions(+), 1 deletions(-)
+
+diff --git a/daemon/gdm-session-worker.c b/daemon/gdm-session-worker.c
+index 15ec0e9..dff3075 100644
+--- a/daemon/gdm-session-worker.c
++++ b/daemon/gdm-session-worker.c
+@@ -1628,7 +1628,8 @@ _open_session_log (const char *dir)
+ 
+         filename = g_build_filename (dir, GDM_SESSION_LOG_FILENAME, NULL);
+ 
+-        if (g_access (dir, R_OK | W_OK | X_OK) == 0 && g_access (filename, R_OK | W_OK) == 0) {
++        if (g_access (dir, R_OK | W_OK | X_OK) == 0 && g_access (filename, R_OK | W_OK) == 0 &&
++            !g_file_test (filename, G_FILE_TEST_IS_SYMLINK)) {
+                 char *filename_old;
+ 
+                 filename_old = g_strdup_printf ("%s.old", filename);
+-- 
+1.7.4.1
+

-- 
ubuntu-backports mailing list
ubuntu-backports@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-backports

Reply via email to