Public bug reported:

**Package:** `qcom-firmware-extract` 20 (stonking/universe; Debian
changelog top entry `qcom-firmware-extract (20) unstable`, 27 Jun 2026).
File it against `qcom-firmware-extract` in Ubuntu; the fix probably also
belongs in Debian.

**Summary**

`-d <search_path>` exists so firmware can be extracted from a
DriverStore copy. When no NTFS partition is present (Windows already
removed, which is when `-d` is most useful), the script exits at the
partition guard before it ever reaches the `search_path` branch.

**Steps to reproduce**

1. Install Ubuntu over the whole disk, so no NTFS partition remains.
2. Mount a copy of `C:\Windows\System32\DriverStore\FileRepository` at 
`<backup>`.
3. Run `sudo qcom-firmware-extract -d <backup>`.

**Expected:** the script skips partition discovery and extracts from
`<backup>`.

**Actual:**

```text
error: Failed to find windows partition
```

Exit status 1. Reproduced twice: on the first install (early October
2026, Concept image, version 20; exact date not re-checked) and on a
clean reinstall on 2026-10-11 (generic daily image, kernel
7.3.0-9-generic, version 20).

**Cause**

`/usr/sbin/qcom-firmware-extract`, lines 108 to 111 in version 20:

```bash
if [ -z "$part" ]; then
        printf "error: Failed to find windows partition" >&2
        exit 1
fi
```

This runs unconditionally. The mount block that needs `$part` starts at
line 113 and is already guarded by `if [ -z "$search_path" ]`.

**Proposed fix**

```diff
--- a/qcom-firmware-extract
+++ b/qcom-firmware-extract
@@ -108 +108 @@
-if [ -z "$part" ]; then
+if [ -z "$part" ] && [ -z "$search_path" ]; then
```

Tested on a local copy (`bash -n` OK). With the change, extraction from
the backup succeeded: 11 files, package `qcom-x1e-firmware-
extracted-x1e80100-dell-latitude7455` version `20261011` built and
installed, firmware loaded after reboot (Adreno X1-85 direct rendering,
ADSP and CDSP running).

Minor, same area: the error string has no trailing newline.

** Affects: qcom-firmware-extract (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2171350

Title:
  qcom-firmware-extract: `-d` still fails with "Failed to find windows
  partition" when Windows is gone

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qcom-firmware-extract/+bug/2171350/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to