Thanks, Adam. Some more comments:
- ah, so SymLink() already uses and returns realpath(), so the loop is
unnecessary. You'll always get the fully canonicalized file name as a
result. This will make the code quite a bit easier.
- This line
full_str_name[strlen(full_str_name)-1] = '\0'; // chop trailing \n
looks fishy. asprintf() does not silently append a line break, so it
looks like you'd chop off the last real character? IMHO this like should
just go.
- Indeed you are right wrt. existing code style, the asprintf()
configure.in check addition is a bit ugly. But don't worry too much
about it, for an Ubuntu patch that's fine. Thanks for sending it
upstream, if they know about it, they can change the patch to whichever
style they prefer.
Thank you!
--
eject -X reports "error while finding CD-ROM name".
https://bugs.launchpad.net/bugs/264071
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
