The only thing I'd mean to do with inotify is to make the /etc/network/interfaces cache in memory always represent the content of the file at this time. It does not mean, that this cache has to be used right now. The comparison with ifupdown seems to indicate a deferred application has to be one option (probably even the default), but what I always do in sw: "If you don't know for sure which way is the right one, make it configurable".
So, my suggestion would be: pass an if_block ** to the parser instead of keeping the static pointer, to create the cached memory structure on init and on inotify. Keep two pointers in the plugin private data: activeFirstIfBlock and currentFirstIfBlock, i.e. separate pointers to separate caches. If the current one is activated the pointer is null'd, if the active one is replaced, it is destroyed. I guess I'll make a proposal in patch form ;-) could nm-tool be extended to have some useful introspection commands? nm-tool plugin ifupdown reload -- reload config of this plugin nm-tool plugin ifupdown config -- dump config of this plugin nm-tool plugin ifupdown status -- dump state of this plugin nm-tool show syslog-level nm-tool set syslog-level debug ... -- [intrepid] network manager does not stop nm-system-settings when stopped https://bugs.launchpad.net/bugs/293751 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
