On Thu, 2008-11-27 at 10:27 +0000, Andy Whitcroft wrote: > As I said the source is unmodified from that in current mainline, so the > source _is_ published. The plan here is to get some testing on these > kernels, and if they work then propose the change for SRU to Intrepid. > At that point the change would also be in our tree. These kernels are > only intended to be temporary builds to get some testing to provide > justification for this SRU nothing more. > > That said the patch is not secret so I've attached it.
Yes, it is obvious that we are testing this driver. I didn't said you are inserting any secrets, I was talking about good habits. IOW I have to support my ubuntu customers, nothing more ;) Even in testing phase it is crucial to publish the source code. If you don't follow the driver development, don't have embedded system skills, you can by accident easily pick up some crazy patch and permanently lockdown the chipset. I could also just put compiled drivers in my attached files but I didn't, I think it si easy to grok why. Back to the subject, how did you get the code you attached? It is broken and if I'm looking there right, it doesn't seems to match head of any regular tree. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=drivers/net/r8169.c;hb=HEAD http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=blob;f=drivers/net/r8169.c;hb=HEAD http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-intrepid.git;a=blob;f=drivers/net/r8169.c;hb=HEAD BTW, if your colleges communicated the (buggy) patch below to the driver maintainer, http://kernel.ubuntu.com/git?p=ubuntu/ubuntu- hardy.git;a=commit;h=de4dc655d9eb5 the actual patch-set didn't missed the 2.6.27 window and didn't wasted your and my time. (Though I lerned a lot about linux driver development :) -- 2.6.26 kernel lacks realtek 8101 support https://bugs.launchpad.net/bugs/256331 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
