Thanks for trying to please everybody.  :-)  A couple of minor comments.
"egrep '^/dev[-_/[:alnum:]]*[-_[:alnum:]]+ {" -- can there be spaces at
the start of the line, or anything other than one space before the open
brace?  controlled_by_LMT() and controlled_by_HDPARM() both echo 0 or 1
to stdout, any reason they can't just "return 0" or "return 1"?  It's
supported by /bin/sh (dash).  Logically, it would make sense then if
controlled_by_*() returned 0 for true, as is normal for shell commands.

-- 
acpi-support's 90-hdparm.sh overwrites hdparm.conf's apm settings
https://bugs.launchpad.net/bugs/318980
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to