There's a bug in the rules around lines 32, 45 and 63:
LD_LIBRARY_PATH=$LD_LIBRARY_PATH
the $ should be escaped to reach the shell or parenthesis should be used to
expand make's var; I recommend the former
Note that upstream version is 1.6.2.0 according to the watch file while
the Debian one is 1.6.2; if the upstream version is incorrect you might
want to strip it in the watch file.
On the upstream stuff, python/louis/Makefile.am makes an improvable usage of
autotools:
LIBLOUIS_SONAME = $(shell source ../../liblouis/liblouis.la ; echo $$dlname)
all:
source ../../liblouis/liblouis.la ; \
sed "s/###LIBLOUIS_SONAME###/$$dlname/" \
< $(srcdir)/__init__.py.in \
> __init__.py
a) this should be computed from CURRENT - AGE, in configure
b) $(shell) is non-GNU make if anybody still cares
c) there's no dependency on the *.la files so it fails with make -C python
d) it should be done by AC_OUTPUT anyway ;-)
I sent a git tree with the fixes I suggested doing during this review to
Debian for merging.
liblouis (1.6.2.0-4) UNRELEASED; urgency=low
* Don't override LD_LIBRARY_PATH completely as this breaks fakeroot.
* Add ${misc:Depends}.
* Run testsuite during build by default.
* Stop installing *.la files in liblouis-dev; the only package
build-depending on liblouis-dev (recursively) is liblouisxml-dev so that's
fine.
* Cleanup rules.
* Add ${shlibs:Depends} to liblouis-dev and python-louis.
* Use AC_CONFIG_FILES/AC_OUTPUT to generate python/louis/__init__.py.
-- Loïc Minier <l...@dooz.org> Thu, 06 Aug 2009 16:27:24 +0100
Approved
** Changed in: liblouis (Ubuntu)
Status: New => Fix Committed
--
[MIR] liblouis
https://bugs.launchpad.net/bugs/391446
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
