This is a trivial package (both code and packaging-wise).  No bugs, no
changes in a long time.

It would be nice if the server team subscribed to Ubuntu bugmail.

I noticed that the existing target to run the tests was outdated and was
not even being run.  I applied the following diff to run the suite:

-common-post-build-indep::      
-       PYTHONPATH=lib ./test_all.py
+binary-install/python-tickcount::
+       
PYTHONPATH=$(cdbs_python_destdir)/usr/lib/pyshared/python$(cdbs_python_current_version)
 python test_tickcount.py


And got:
"""
======================================================================
FAIL: test_difference_wrap (__main__.TickCountTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_tickcount.py", line 44, in test_difference_wrap
    self.assertEqual(tickcount.difference(oldcount, newcount), 20)
AssertionError: 21 != 20

----------------------------------------------------------------------
Ran 2 tests in 0.001s
"""

So I'm not approving because that suggests something is wrong.  If
that's fixed (either by fixing a bug or fixing the testsuite -- in
either case it would be nice if the above patch were included so this
would get caught in the future), it'd be approved.

** Changed in: tickcount (Ubuntu)
       Status: New => Incomplete

** Changed in: tickcount (Ubuntu)
     Assignee: Michael Terry (mterry) => (unassigned)

-- 
MIR for python-tickcount.
https://bugs.launchpad.net/bugs/489264
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to