I'd like to include this upstream, but I am not entirely convinced of the approach taken in this patch. Adding an additional component that is essentially a copy and paste of the existing SystemTray component isn't really ideal. There is way too much code duplication and this will become a maintenance nightmare.
The better approach would be to modify SystemTray to use either a gtkStatusIcon or the Appindicator possibly based on a configuration value or simply in an order of preference, eg, use the Appindicator if the 'import appindicator' succeeds. I haven't taken a hard look at the patch, but it's likely that this could be accomplished with far less new lines of code. There are other options too, you could for instance, create a base class and subclass the SystemTray and Appindicator respectively. Thanks for your time in adding this functionality, I hope that we can add it to Deluge in the future. -- indicator for deluge https://bugs.launchpad.net/bugs/584669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
