>From a quick look, there seems to be trivial indentation mismatches: + mount $UBOOT_PART $TMPMOUNT + tmp=$(tempfile) in general flash-kernel uses tabs upstream, and pretty much never spaces.
Writing to $tmp.uboot is unsafe as this filename is predictable; would be nicer to always generate a new tempfile (one for kernel, one for initrd), or use a tempdir and stores them below, or reuse the tempfile but only delete it once you're finished with it. Otherwise, this looks good to me. I guess we don't want to support RedBoot anymore, nor upgrades from RedBoot. Is "imx51" the only kernel extension we want to support? What about linux-linaro-mx51? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723082 Title: flash-kernel doesn't handle uboot in mx51evk -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
