Public bug reported:

/etc/network/if-up.d/gogoc contains inconsistencies that subvert the
advertised purpose, and, more importantly, breaks ifup:

$ sudo ifup sixxs
Tunnel Information for T98765:
POP Id      : deabc01
IPv6 Local  : 2001:abcd:ef01:2345::2/64
IPv6 Remote : 2001:abcd:ef01:2345::1/64
Tunnel Type : ayiya
Adminstate  : enabled
Userstate   : enabled
run-parts: /etc/network/if-up.d/gogoc exited with return code 1

And as a consequence, the post-up section for sixxs isn't executed,
causing the route to be missed.

The cause is in the latter script itself:

     1  #!/bin/sh
     2  # Reload the gogoc daemon when an interface comes up.
     3  
     4  set -e
     5  
...

    16  # Restart only if the daemon was running already
    17  /usr/bin/pgrep -f ^/usr/sbin/gogoc >/dev/null
    18  if [ $? != 0 ]; then
    19    exit 0
    20  fi
    21  invoke-rc.d gogoc restart
    22  
    23  exit 0


The set -e prevents lines 18 - 20 from ever being executed - if there is no 
match, pgrep exits with code 1, and set -e causes immediate termination of the 
script, passing the exit code on.

Lines 17 ... 20 need to be collapsed to:

pgrep (arguments) >/dev/null || exit 0

alternatively rewritten as:

if pgrep (arguments) >/dev/null ; then
  invoke-rc.d gogoc restart
fi
exit 0

Either is safe.

For reference, this is the relevant part from my
/etc/network/interfaces:

...
auto sixxs
iface sixxs inet6 manual
        up          /etc/init.d/aiccu start
        post-up     ip -6 route add 2000::/3 dev sixxs

        pre-down    ip -6 route del 2000::/3 dev sixxs
        down        /etc/init.d/aiccu stop

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: gogoc 1:1.2-2
ProcVersionSignature: Ubuntu 2.6.38-8.42-generic 2.6.38.2
Uname: Linux 2.6.38-8-generic x86_64
Architecture: amd64
Date: Tue Jun 28 00:16:00 2011
ProcEnviron:
 LANGUAGE=de:en
 PATH=(custom, no user)
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
SourcePackage: gogoc
UpgradeStatus: Upgraded to natty on 2011-05-02 (56 days ago)

** Affects: gogoc (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: amd64 apport-bug natty

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/802759

Title:
  /etc/network/if-up.d/gogoc breaks ifup post-up scripts

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gogoc/+bug/802759/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to