(note the actual uploaded lucid fix does also add a comment for LOG_FILE, though that's not shown in the debdiff above) (sadly, --logfile= would have worked, but '--log-file' is not recognized :)
** Description changed: + ======================================= + SRU Justification: + 1. Impact: startup modifications specified in /etc/default/cgred.conf are ignored. + 2. How bug was addressed: the cgred init file is fixed. + 3. Patch: see attached debdiff. + 4. TEST CASE: add 'LOG_FILE=/var/log/snood' to /etc/default/cgred.conf. It will be ignored. + 5. Regression potential: if people have updated their /etc/default/cgred with errors, which had up to now been ignored, then those errors would now be seen. + ======================================= + The /etc/init.d/cgred startup script looks for the file /etc/default/cgred.conf rather than /etc/default/cgred. Additionally, the script makes no use of the DAEMON_OPTS variable found in the default file. Lastly, the log file parameter as provided won't work. (the daemon exits with a usage error) One has to use the -f option instead of --log-file in order for the daemon to start. It might be good to document LOG_FILE via a comment in /etc/default/cgred. - -if [ -f "/etc/default/cgred.conf" ] ; then - . /etc/default/cgred.conf - OPTIONS="$NODAEMON $LOG" +if [ -f "/etc/default/cgred" ] ; then + . /etc/default/cgred + OPTIONS="$NODAEMON $LOG $DAEMON_OPTS" - if [ -n "$LOG_FILE" ]; then + if [ -n "$LOG_FILE" ]; then - OPTIONS="$OPTIONS --log-file=$LOG_FILE" + OPTIONS="$OPTIONS -f $LOG_FILE" - fi + fi -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/825598 Title: cgred init script references wrong default file and uses bad options To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libcgroup/+bug/825598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
