Thanks for taking the time to prepare this patch.

Some feedback on the update:

1) debian/changelog

athena-jot (9.0-5yandex0) oneiric; urgency=low

a) oneiric development has close since its now been released - your fix
needs to target precise.

b) 9.0-5yandex0 works but is not inline with the way the version should
be incremented - 9.0-5ubuntu1 would be appropriate.

* Use arc4random number generation instead of time based

You should add (LP: #804355) to the changelog entry - that way this bug
would be closed when the package is accepted into the archive.

2) patching

This is quite an older package and pre-dates some of the newer package
format options; it would be nice to switch this package over to
source/format 3.0 and provide the fixes as a patch rather than changing
the upstream source code directly.

See http://wiki.debian.org/Projects/DebSrc3.0

Thanks for you work so far!

Cheers

James

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/804355

Title:
  jot random number generator broken in batch jobs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/athena-jot/+bug/804355/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to