For signon-plugin-oauth2, it looks mostly fine. Love the tests! No
blockers, but I do have some questions.
Questions:
Why is libqtwebkit-dev a Build-Dependency? It didn't look like it was used.
Why is there a tests package in debian/control? Seems like that's not
something users would want to install, vs just being a part of the build.
Nits:
Maintainer should be "Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>"
Debhelper 9 would be nice.
Passing off to security team for a quick review of the oauth1 and oauth2
implementations. Not sure if it's needed, but better safe than sorry.
** Changed in: signon-plugin-oauth2 (Ubuntu)
Status: New => Incomplete
** Changed in: signon-plugin-oauth2 (Ubuntu)
Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1029549
Title:
[MIR] online-accounts and friends
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/account-plugins/+bug/1029549/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
