> > (In reply to Patrick McManus [:mcmanus] from comment #41) > > ::: browser/base/content/test/browser_bug435325.js > > @@ +40,5 @@ > > > finish(); > > > } > > > > > > registerCleanupFunction(function() { > > > + Services.prefs.setIntPref("network.proxy.type", 2); > > > > you need at least push/pop. Please comment that this is necessary because > > the mochitest proxy runs n localhost and localhost is now reachable even > > when offline. > > Added the comments, but wasn't clear if the "push/pop" referred to something > else?
by push/pop I mean you need to save the original state of the pref and restore that rather than setting it explicitly to "2" when we're done, in case that's not what is used in the future. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/367531 Title: firefox should be smarter about offline access To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/367531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs