OK - I applied the current patch to the 0.12.90 tarball and built.  (I
had to use Vala 0.17.6.)  I noticed a few things:

- In the Online Accounts panel, the list of accounts that integrate with
Shotwell includes Facebook and Google but not Yahoo!/Flickr.  Is Flickr
support on the way?  If so, will it be tracked in this bug or is there a
different bug for it?

- When I choose my Facebook account in the publishing pane, I see a slew
of critical errors in the terminal where I've run Shotwell:

(shotwell:2089): GLib-GIO-CRITICAL **: g_dbus_gvalue_to_gvariant: assertion 
`type != NULL' failed
(shotwell:2089): GLib-CRITICAL **: g_variant_new_variant: assertion `value != 
NULL' failed
(shotwell:2089): GLib-CRITICAL **: g_variant_get_type: assertion `value != 
NULL' failed
(shotwell:2089): GLib-CRITICAL **: g_variant_type_is_subtype_of: assertion 
`g_variant_type_check (type)' failed
(shotwell:2089): GLib-CRITICAL **: g_variant_builder_add_value: assertion 
`!GVSB(builder)->expected_type || g_variant_is_of_type (value, 
GVSB(builder)->expected_type)' failed
(shotwell:2089): GLib-CRITICAL **: g_variant_builder_end: assertion 
`GVSB(builder)->offset >= GVSB(builder)->min_items' failed

Publishing does seem to work, however.

- In Makefile.plugins.mk, I noticed that you've added new definitions
for EXT_PKGS/PKGS which replace the old ones.  Did you mean to use += to
append to the old definitions?  (If not, your patch should remove the
old definitions).

I'll emphasize that I haven't read the code - these are just points I
noticed when trying to build and run.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1046461

Title:
  [UIFe] [FFe] UOA integration needs to support multiple accounts

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to