Functionally, the patch looks pretty good to me. Thanks for the attention to detail with respect to the signal disconnection.
One small detail is that the function you introduce should be marked 'static' (since it is not used outside of the current file). Otherwise, everything else looks fine. A comment about why this function exists is probably also reasonable since it's non-obvious from just looking at it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1071950 Title: gnome-settings-daemon dconf to gconf plugin causes settings to be lost To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1071950/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
