Hello test, or anyone else affected, Accepted libsecret into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libsecret/0.11-0ubuntu0.12.10.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Description changed: + [Impact] + This bug makes vinagre unusable with existing connection profiles upon upgrade to 12.10. + + [Test Case] + 1. Install Ubuntu 12.04. + 2. Use vinagre to connect to a vnc server that's configured to require a password. Do not save the password. + 3. Upgrade to Ubuntu 12.10. + 4. Try again to connect to the server. Confirm that it fails with a segfault. + 5. Upgrade to the libsecret-1-0 in -proposed. + 6. Try to connect to the server again. Confirm that it succeeds. + + [Regression Potential] + This is a new upstream version release specifically to fix this crasher bug. There appears to be no risk of regression. + on ubuntu 12.10 ii vinagre 3.6.0-0ubuntu1 amd64 remote desktop client for the GNOME Desktop when connecting to vnc which requires password authentication vinagre will crash this is because the usernaem inside the vinagre_tab_find_credentials_in_keyring function will be null The following patch will resolve it diff --git a/plugins/vnc/vinagre-vnc-tab.c b/plugins/vnc/vinagre-vnc-tab.c index 10bed13..d591a29 100644 --- a/plugins/vnc/vinagre-vnc-tab.c +++ b/plugins/vnc/vinagre-vnc-tab.c @@ -492,7 +492,10 @@ vnc_authentication_cb (VncDisplay *vnc, GValueArray *credList, VinagreVncTab *vn - - if (need_password || need_username) - { + + if (need_password || need_username) + { - vinagre_tab_find_credentials_in_keyring (tab, &username, &password); + if (vinagre_connection_get_username (conn) != NULL) + { + vinagre_tab_find_credentials_in_keyring (tab, &username, &password); + } - if ( (need_username && !username) || (need_password && !password) ) - { - host = vinagre_connection_get_best_name (conn); + if ( (need_username && !username) || (need_password && !password) ) + { + host = vinagre_connection_get_best_name (conn); ** Changed in: libsecret (Ubuntu Quantal) Status: Triaged => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1071055 Title: vinagre crashed on connecting to vnc To manage notifications about this bug go to: https://bugs.launchpad.net/libsecret/+bug/1071055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
