Hi Axel,
I can't find Ulric's patch in neither in 4.3.10 and 4.3.11 from
http://xymon.sourceforge.net/ nor in 4.3.7-1. They all still contain the bug in
strfunc.c:
| static strbuffer_t *result = NULL;
| char *inp, *endp;
| char c;
|
| if (!result) result = newstrbuffer(4096);
| clearstrbuffer(result);
Might be the patch was in in for a short time.
But they all use /var/lib/xymon and /etc/xymon which is not suitable to the
very complex installations of Xymon Servers running Ubuntu 10.04LTS (lucid) and
12.04LTS (precise). Speaking from the Admin's view.
They are using /etc/hobbit at the moment, and might loose their whole
configuration and data when this is changed withing the stable release.
The Bug came in with the 2011-1716 Patch.
And should be all affected by this Bug. The buffer result is reused before the
code is copied out of it.
There are two ways to fix:
- One way would be to remove the static. Which was set to prevent memory
leaks. When doing this the memory must be freed in the calling functions again,
at least when they are used in long running daemons.
- Ulric choses the other one. This fixes the bug for a maximum amount of 10
concurrently used arguments, but is aware of producing memory leaks at all.
I'm using packages containing a modified Version of Ulric's Patch since
2013-01-29 (some days after Peters post I've put them in my PPA). They does'nt
contain the
|#if 0
| static strbuffer_t *result = NULL;
|#else
and the #endif of course. This if IMHO assumes that the fix could be disabled
by turning the if to 1, which wouldn't work.
I'm sorry I selected the wrong patch file in #22. I'll corect it, now.
Kind regards,
Lars
** Patch added: "This is what I wanted to post in #22 (Patch for lucid for the
patch dir)."
https://bugs.launchpad.net/ubuntu/+source/xymon/+bug/1103428/+attachment/3685152/+files/lk1103428-lucid_2013-01-29.patch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1103428
Title:
Xymon history page does not work
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xymon/+bug/1103428/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
