Nic, please make a small MR that fixes the issues. Don't include it in your large upcoming MR because that one will take too long to review, and it is clearer if separate bugfixes are in separate MRs.
** Summary changed: - API break: ItemSelector.enabled changed to read-only + API break: ItemSelector.expanded changed to read-only ** Description changed: - system-settings makes use of ListItem.ItemSelector.enabled in a few + system-settings makes use of ListItem.ItemSelector.expanded in a few places. In https://code.launchpad.net/~nicolas-doffay/ubuntu-ui-toolkit /selectors-multi-selection this was changed to a read-only property and 'alwaysExpanded' provided to covers some of the use-cases for setting expanded before. This is an API break which IMO shouldn't have happened. Could it be fixed? It breaks a lot of ubuntu-system-settings. For example: laney@raleigh> system-settings cellular QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No space left on device unity::action::ActionManager::ActionManager(QObject*): Could not determine application identifier. HUD will not work properly. Provide your application identifier in $APP_ID environment variable. UCUriHandler: Empty "APP_ID" environment variable, ignoring. file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/PageWrapperUtils.js:42: Error: Error while loading page: file:///usr/share/ubuntu/settings/system/qml-plugins/cellular/PageComponent.qml:65 Invalid property assignment: "expanded" is a read-only property file:///usr/lib/x86_64-linux- gnu/qt5/qml/Ubuntu/Components/ListItems/SingleControl.qml:59: Unable to assign [undefined] to bool -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1248646 Title: API break: ItemSelector.expanded changed to read-only To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1248646/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
