Comment on attachment 8339517
proposed fix

Review of attachment 8339517:
-----------------------------------------------------------------

This looks generally reasonable, though currently it is bitrotted so I
can't test it out.

Re the test failures, I wonder if you're hitting Linux versus non-Linux
line endings or something like that.

::: mail/locales/en-US/chrome/messenger/messengercompose/composeMsgs.properties
@@ +316,5 @@
>  ## reply header in composeMsg
>  ## user specified 
>  mailnews.reply_header_originalmessage=-------- Original Message --------
>  
> +## Strings used in the corporate reply headers table 
> (mailnews.reply_header_type = 4)

Should we re-use existing strings that we use for forward? I'm not sure
there's likely to be a need for separate ones here.

::: mailnews/compose/public/nsIMsgCompose.idl
@@ +247,5 @@
>                                                in nsStringRef aBuf, 
>                                                in nsStringRef aSignature,
>                                                in boolean aQuoted,
> +                                              in boolean aHTMLEditor,
> +                                              in boolean aPrefixIsHTML);

Please add documentation for this function, in particular the various
parameters and what prefix is used for.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/119441

Title:
  enhance thunderbird to include option to forward original msg in reply

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/119441/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to