Hello Whoopie! Thank you for your work on bringing in the new upstream version to Ubuntu. I checked the package briefly and found a few issues:
- Even though the original has a lot of lintian errors by itself, I noticed that your package introduced one additional one: dh-clean-k-is-deprecated. You should use dh_prep instead of dh_clean -k in debian/rules. - Most of the added quilt patches are not documented in the changelog. The best rule is to document every added patch so that a person reading the changelog knows about every difference from the upstream tarball. - Some of the quilt patches make super sense (like those that get us closer to how it worked in the previous release) but others - more without any documentation - are hard to understand. For instance patches/07_force-hw-address.patch is a rather big patch, so I'm wondering about if it's not changing the new release too much. - I know that the rp-pppoe doesn't have a nice upstream issue tracking architecture, and it might be hard contributing to it, but maybe you could anyway try submitting all those patches upstream before we introduce this version to Ubuntu? As mentioned before, generally we would prefer not to change the software from the ideas of upstream developers too much without them giving approval. - Last thing: are you sure you wouldn't prefer to use your real name in the changelog entry? Generally not a blocker, but it's easier from the copyright/authorship perspective. Thanks again! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/705880 Title: please update pppoe to new upstream version To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/rp-pppoe/+bug/705880/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
