Launchpad has imported 5 comments from the remote bug at https://bugzilla.xfce.org/show_bug.cgi?id=11212.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2014-10-02T17:46:51+00:00 Evangelos Foutras wrote: Beginning with glib >= 2.41, g_app_info_get_all_for_type() no longer puts the default application in front of the list. (See glib commit 6fd5a8c. [1]) Thunar seems to depend on the removed behavior to correctly pick the default application for the selected file(s), and thus needs to be adjusted to use g_app_info_get_default_for_type() instead. I also found a Debian bug report about this with reproduction details. [2] [1] https://git.gnome.org/browse/glib/commit/?id=6fd5a8c [2] https://bugs.debian.org/763726 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1382977/comments/0 ------------------------------------------------------------------------ On 2014-10-03T04:34:14+00:00 Evangelos Foutras wrote: Created attachment 5675 Fix "Open With" default app with glib >= 2.41 Here's a quick and dirty fix; maybe someone else can come up with a more elegant solution. :) Reply at: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1382977/comments/1 ------------------------------------------------------------------------ On 2014-10-03T04:45:18+00:00 Evangelos Foutras wrote: Created attachment 5676 Fix "Open With" default app with glib >= 2.41 (I had to fix that "frond" typo. :3) Reply at: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1382977/comments/2 ------------------------------------------------------------------------ On 2014-10-14T11:07:50+00:00 Guido Berhoerster wrote: Created attachment 5690 ensure thunar_file_list_get_applications() has the default application as the first element of the returned list Nice find. Since thunar_file_list_get_applications() and its only consumer thunar_launcher_update_idle() are the only places that expect g_app_info_get_all_for_type() to have the default application as the first element, I don't think it's necessary to expose something like thunar_g_app_info_get_all_for_type(). Attached is a slightly revised patch that inlines the list reordering into thunar_file_list_get_applications(). Reply at: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1382977/comments/3 ------------------------------------------------------------------------ On 2014-10-14T20:04:48+00:00 Evangelos Foutras wrote: (In reply to Guido Berhoerster from comment #3) > Created attachment 5690 [details] > ensure thunar_file_list_get_applications() has the default application as > the first element of the returned list > > Nice find. Since thunar_file_list_get_applications() and its only consumer > thunar_launcher_update_idle() are the only places that expect > g_app_info_get_all_for_type() to have the default application as the first > element, I don't think it's necessary to expose something like > thunar_g_app_info_get_all_for_type(). Attached is a slightly revised patch > that inlines the list reordering into thunar_file_list_get_applications(). I agree that this is the preferred way to fix this. I tested your patch and it works fine (as expected). Please note that submitting a patch created using 'git format-patch' with proper commit message would ease the job of whoever commits this. It would also include proper credit for your work once it's applied. :) Reply at: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1382977/comments/4 ** Changed in: thunar Status: Unknown => Confirmed ** Changed in: thunar Importance: Unknown => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1382977 Title: Default open with wrong To manage notifications about this bug go to: https://bugs.launchpad.net/thunar/+bug/1382977/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
