* debian/copyright isn't fully correct, it contains quite some copyright that 
are not listed:
libappstream-glib/as-utils.c: LGPL (v2.1 or later)
  [Copyright: 2014 Richard Hughes <rich...@hughsie.com> / 2011 Paolo Bacchilega 
<pao...@src.gnome.org>]
libappstream-glib/as-cleanup.h: LGPL (v2.1 or later)
  [Copyright: 2014 Richard Hughes <rich...@hughsie.com> / 2012 Colin Walters 
<walt...@verbum.org>]
libappstream-builder/asb-package-alpm.c: LGPL (v2.1 or later)
  [Copyright: 2014 Fabien Bourigault <bourigaultfab...@gmail.com>]

And moreā€¦ please check the copyrights again, and maybe propose some
patches to debian?

* I guess until the ubuntu desktop team switch to an application
requiring appstream-glib, you should get someone from the gnome ubuntu
team to subscribe to bug reports.

* debian/rules:
override_dh_auto_test:
    # Don't run tests, they are always failing at time (20140924)
-> can you try to reenable them, and check if they are passing now? Maybe check 
with the debian maintainer and upstream about them? If theuy need to run as 
autopackage tests, maybe we can ship them as such?

* debian/control:
- the package build-dep against libqt4-dev. Why such? It seems nowhere there is 
any qt4 mention in the code. Some are qt3, but it's just when analyzing any 
application on the builder (which isn't shipped by default). Can we get away of 
that dep if it's not used at all?
- Would be nice to get that one fixed/reported upstream:
W: appstream-glib-doc: extended-description-line-too-long

Otherwise, the code looks good!

** Changed in: appstream-glib (Ubuntu)
       Status: New => Incomplete

** Changed in: appstream-glib (Ubuntu)
     Assignee: Didier Roche (didrocks) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1416617

Title:
  [MIR] appstream-glib

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/appstream-glib/+bug/1416617/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to