Comment on attachment 8561105
Pad heap allocations passed to flag_qsort() on x86 Linux to work around gcc bug 
affecting Ubuntu packages

Approval Request Comment
[Feature/regressing bug #]: not a regression in our codebase
[User impact if declined]: #3 topcrash on Linux, specific to 32-bit 
Ubuntu-distributed builds.  Firefox will randomly crash on 32-bit Linux builds 
the first time the user uses a textarea or otherwise does something that 
initializes the spellchecker.  (It only crashes a small percentage of the time, 
but it affects a large number of users.)
[Describe test coverage new/current, TreeHerder]:  None.  Just landed on 
mozilla-inbound.  I don't know of any way to test that the fix works without 
shipping it on the release channel.
[Risks and why]: Low risk; it's padding a few allocations in the spellcheck 
code with 2 extra bytes on all 32-bit Linux builds.
[String/UUID change made/needed]: no

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1322784

Title:
  Firefox crashes in flag_qsort during spellchecker initialization on
  x86 due to gcc bug

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1322784/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to