On 03/11/2015 12:14 PM, Tim Waugh wrote: >>From a quick glance, this looks wrong: > > ``` > /* If auto shutdown is active we have perhaps scheduled a timer to shut down > due to not having queues any more to maintain, kill the timer now */ > if (autoshutdown && autoshutdown_exec_id && > cupsArrayCount(remote_printers) > 0) { > debug_printf ("cups-browsed: New printers there to make available, > killing auto shutdown timer.\n"); > g_source_destroy(g_main_context_find_source_by_id(NULL, > autoshutdown_exec_id)); > autoshutdown_exec_id = 0; > } > ``` > > Why are you calling g_source_destroy() rather than g_source_remove()? >
I do not know why I have used "g_source_destroy()", perhaps seeing some example somewhere on the internet. What is the difference between "g_source_destroy()" and "g_source_remove()"? Can I safely use "g_source_remove()" without breaking something else? Or do I even have to use "g_source_remove()" because the other is missing to do something important? Till -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1427344 Title: cups-browsed crashed with SIGSEGV in timeout_free() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cups-filters/+bug/1427344/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs