Hi Andrey, (In reply to comment #45) > Stefan [Bühler], do you plan to finish work on the patch? Do you need help > with code review? (I just added Aaron Ballman, who is code owner for > attributes).
I think the attributes part of the patch is quite good compared with the mangling part... perhaps it should be split into a separate patch. Regarding the mangling I'm not too happy with my patch. I don't understand what most of the mangling code did before to actually know where to insert the tagging code. This is C++ on a level I don't usually touch; I'm not familiar with all the terms (<unscoped-template-name>, <source-name>, ...) and just keep guessing what they do. Also I don't like using recursion to determine the inherited abi tags; I think using temporary strings instead of directly writing to the stream would solve this. All in all I hoped to get some feedbacks how things are done or should look like; I don't mind if someone else wants to take over and rewrite the mangling :) I planned looking at the original gcc code some day, but didn't get around doing that either; maybe others can help with the documentation too (how the abi tag mangling actually should look like). More "examples" certainly wouldn't hurt either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1488254 Title: clang++ no longer ABI-compatible with g++ To manage notifications about this bug go to: https://bugs.launchpad.net/llvm/+bug/1488254/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
