As mentioned in a duplicated LP, I think the vlan up/down script could
be simplified.

The part extracting VLANID and IF_VLAN_RAW_DEVICE seems overly complex.
The "case" statement already ensures we operate on vlan device so I
think something much simpler like this would work:

  VLANID=`echo $IFACE|sed "s/[^.]\+\.\([0-9]\+\).*/\1/; s/^0//"`
  IF_VLAN_RAW_DEVICE=`echo $IFACE|sed "s/\([^.]\+\)\.[0-9]\+.*/\1/"`

This is also easier to read.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541678

Title:
  if-post-down.d/vlan and if-pre-up.d/vlan should support en* interfaces

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/vlan/+bug/1541678/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to